This repository was archived by the owner on Apr 28, 2023. It is now read-only.
ScheduleTree: replace comparison operators with named functions #583
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proceeding with ScheduleTree evolution plan (#553)
This PR replaces overloaded comparison operators with two functions,
nodeEquals
andtreeEquals
. The main motivation for this change: after grafting ScheduleTreeElem* onto ScheduleTree in the inheritance structure we ended up withoperator==
comparing subtrees if called on ScheduleTree and nodes if called on instances of other classes. I argue that the behavior of default comparison operator is unintutitive for tree-like structure. Therefore, introducing explicitly-named comparison functions that make the intention clear is an improvement.As an additional benefit, regular member functions can be declared virtual, unlike operators. With this approach, each subclass needs to override one abstract function that does node-to-node comparison while subtree comparison is handed automatically. Previously, it would have been necessary to also modify the clunky macro-based logic in one of the comparison operators.